Add a Makefile #1247
Merged
Add a Makefile #1247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
| @dpkp @jeffwidman Any commands you want to add/change? |
dpkp reviewed Oct 8, 2017
Makefile Outdated
| # Some simple testing tasks (sorry, UNIX only). | ||
| | ||
| FLAGS= | ||
| KAFKA_VERSION=0.11.0.0 |
| SCALA_VERSION=2.11 | ||
| | ||
| setup: | ||
| pip install -r requirements-dev.txt |
Owner
There was a problem hiding this comment.
probably want a virtualenv here, dont we? or perhaps --user ?
Collaborator Author
There was a problem hiding this comment.
I would prefer to assume the virtualenv is already installed and activated. There are a lot of different ways to do that, like pyvenv, virtualenv, virtualenvwrapper and so on.
Collaborator Author
There was a problem hiding this comment.
I can change the name to something like setup-local
Owner
| might be nice to also include a command to fetch / install server artifacts via build_integration.sh |
…ject, generate docs and run tests.
tvoinarovskyi force-pushed the add_makefile branch from a1788c9 to 2d36082 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With this, users which are less familiar with the project can easily build, generate docs and run tests.