feat: Add possibility to clear search on node selection #76
Conversation
| Looks good. We should add this options to Options story under docs as well. |
| So how do you want to proceed. We merge the first commit then I do an exemple in codesandbox and we merge again? Or do we blindly hope my second commit will work? ;) |
| I use the options story as an end user test (this way we don’t leave anything to fate). Add an option there, test out if the component does what it’s supposed to and if everything checks out, I know I’m good to go. Bonus, we get free documentation with real live examples. Codesandbox is good but I don’t think we need to create one for every little flag. People can play with the base sandbox or can checkout docs for examples. Makes sense? Oh wait, is the options story part of the partial state PR? If so, I guess I’ll have to merge it soon. I was hoping codeclimate support can fix the issues first but maybe I’ll skip it for that PR ( |
| I don't see the options entry in my doc so I think it's in your current PR. (I was asking myself how you do local test with this process but now I know. :)) |
Gregcop1 force-pushed the feat-clear-on-select branch from c0f308d to 9c37377 Compare | @mrchief I've updated the "story" part |
src/index.js Outdated
| }) | ||
| if (this.props.simpleSelect) this.resetSearch() | ||
| this.notifyChange(this.treeManager.getNodeById(id), tags) | ||
| if (this.props.clearSearchOnChange) { |
There was a problem hiding this comment.
This can probably be combined with if (this.props.simpleSelect)
| Would you mind running |
| What do you want me to check in |
3 participants
No description provided.