Bugfix #537 issue and Correct namespace and StringEncoding default value #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| ping! |
Memoyu approved these changes Sep 18, 2024
| I need a quick search ranking method on Twitter, can you teach me? I will offer generous rewards TG：@ajiegly |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Bugfix issue System.MissingMethodException when using EasyCaching.Serialization.MemoryPack with .NET 7.0 and above #537
Correct namespace
This package has nothing to do with
EasyCaching.Serialization.JsonSo this namespace is wrong in this code. (now is fixed by this PR)
StringEncoding default value
According to the MemoryPack's code the default value for this should be
StringEncoding.Utf8but the current implementation defaults toUtf16because no value has been set and the first value of that enum isUtf16. (now is fixed by this PR)