Clean-up public and internal pipelines #8927
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dotnet-policy-service bot added the PR 
singhashish-wpf approved these changes Mar 19, 2024
mmitche requested changes Mar 19, 2024
Member
mmitche left a comment
mmitche left a comment There was a problem hiding this comment.
WPF runs internal PRs (not yet for .NET 9, but eventually), and at that point many of these changes will be incorrect. Essentially, it won't be correct to assume that PR == public.
dotnet-policy-service bot added the 📭 waiting-author-feedback 
Contributor
| @mmitche clearly has more context than I do so I defer to his judgement. Apologies for the troubles. |
rchauhan18 added * NO MERGE * 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
We have separated the public and internal pipelines, so we can remove the conditions throughout that are checking internal vs. public to make things more readable.
Microsoft Reviewers: Open in CodeFlow
CC: @RussKie @lonitra