Adding Stable Branding .NET 8 RTM #8338
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ghost requested review from 
Contributor
| @harshit7962 - can you please add more details, why the change is required also attach any issue if it exists. |
Kuldeep-MS approved these changes Oct 20, 2023
Contributor
Kuldeep-MS left a comment
Kuldeep-MS left a comment There was a problem hiding this comment.
As discussed, changes look good to me.
dkurepa requested changes Oct 24, 2023
Member
dkurepa left a comment
dkurepa left a comment There was a problem hiding this comment.
I don't think this change is needed, since WPF doesn't have any shipping packages.
Has something changed, do we construct some shipping packages in wpf now?
ghost added the 📭 waiting-author-feedback 
Contributor
| We don't produced shipping packages. This happened before confirmation. Closing the PR. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Adding StabilizePackageVersion tag to enable stable branding.
Testing
Local build pass
Microsoft Reviewers: Open in CodeFlow