Skip to content

Conversation

vatsan-madhavan
Copy link
Member

This PR adds sources for the following assemblies:

  • WindowsBase
  • PresentationCore
  • PresentationFramework
  • DirectWriteForwarder
  • ReachFramework
  • System.Windows.Input.Manipulations
  • UIAutomation
    • UIAutomationClient
    • UIAutomationClientSideProviders
    • UIAutomationProvider
    • UIAutomationTypes

/cc @dotnet/wpf-developers
/cc @grubioe, @ryalanms , @rladuca, @stevenbrix , @amit-kabra , @fabiant3 , @miguep , @ojhad

@dotMorten
Copy link
Contributor

dotMorten commented May 22, 2019

WOOHOO! ✋ 👏 🎉 🎆 🍻

@ryalanms ryalanms self-requested a review May 22, 2019 19:22
@amit-kabra
Copy link
Contributor

Yes!

@fabiant3-zz
Copy link

Way to go team!!

@rickbrew
Copy link

Best Pull Request of 2019 Award

https://www.youtube.com/watch?v=DSqNLA1pWxk

@mdtauk
Copy link

mdtauk commented May 22, 2019

A step closer to being able to do some cool things with WPF control templates when running under WinUI 3.0 maybe. Fluent design for controls to look comfortable alongside UWP XAML.

Fluent.NormalColor.xaml

or

Fluent.Light.xaml

Fluent.Dark.xaml

😄

Copy link
Member

@rladuca rladuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the newer targets glue to make everything work with wpf_int. Nothing jumps out, looks good. Proof of the pudding is in the build (and DARC flow). : - )

@matijagrcic
Copy link

Amazing!

@vatsan-madhavan vatsan-madhavan merged commit ae17905 into master May 22, 2019
@vatsan-madhavan vatsan-madhavan deleted the dev/vatsan/big3-oss-prep branch May 22, 2019 22:58
@merriemcgaw
Copy link
Member

Awesome guys!! 🥇 🎆 🍾

@lindexi
Copy link
Member

lindexi commented May 23, 2019

Congratulate !!!

@walterlv
Copy link
Contributor

Excellent! WPF is closer and closer to fully open-source.

@h82258652
Copy link

Great! The best PR in 2019.

@vatsan-madhavan
Copy link
Member Author

vatsan-madhavan commented May 23, 2019

Folks might have missed this, but there was another set shortly after: #727

@thomasclaudiushuber
Copy link
Contributor

Wow, happened much sooner than I expected it! Congrats to the whole team. Great and important milestone!

@AlexBorsody
Copy link

about time, great job.

@Murgio
Copy link

Murgio commented May 25, 2019

Love it, this is the single best thing that could possibly happen. 👏 👏

@schungx
Copy link

schungx commented Jun 13, 2019

Now all we need is some nice gents to port it to Linux... 😆

@weltkante
Copy link

@schungx the most important part, the rendering engine, is still missing

@lindexi
Copy link
Member

lindexi commented Jun 13, 2019

@weltkante You are right and the WPF teams say that they do not plan to make WPF cross-platform recently.

@weltkante
Copy link

@lindexi other people can still port it, the MIT license should allow it - thats what @schungx was talking about - it's just that Microsoft won't do the work for you, and that they'll probably not include it into the main WPF github/nuget repository - but that doesn't prevent a working implementation

@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet