Skip to content

Update SchemaPP.cs #11170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update SchemaPP.cs #11170

wants to merge 1 commit into from

Conversation

@wstaelens
Copy link
Contributor

@wstaelens wstaelens commented Oct 13, 2025 •
edited by dotnet-policy-service bot
Loading

removed ArrayList (boxing/unboxing)

Fixes a part of #8406

Main PR

Description

Removing Arraylist, better performance, no boxing/unboxing.

Customer Impact

Low

Regression

Testing

None

Risk

Low

Microsoft Reviewers: Open in CodeFlow
@wstaelens
Update SchemaPP.cs
3fe6989 
removed ArrayList (boxing/unboxing)
@wstaelens wstaelens requested a review from a team as a code owner October 13, 2025 11:56
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Oct 13, 2025
@lindexi
Copy link
Member

lindexi commented Oct 14, 2025

Cc @h3xds1nz

Do you changed the src/Microsoft.DotNet.Wpf/src/ReachFramework/Resources/generator/SchemaPP.cs files?

Also in #11171
@h3xds1nz
Copy link
Member

@lindexi I wasn't touching the ReachFramework generator, it is never ran nor used.

As for #11171, I wasn't changing these either. That one is ran currently on-demand, not even part of build infra.

Unlike other PRs, these don't hurt anyone though. It makes no difference but it's an okay change.
@wstaelens wstaelens closed this by deleting the head repository Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage

3 participants

@wstaelens @lindexi @h3xds1nz