Skip to content

fix: Unable to pack Microsoft.VisualBasic.Forms #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2019
Merged

fix: Unable to pack Microsoft.VisualBasic.Forms #2396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eng/packageContent.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

<PropertyGroup>
<IntellisenseXmlFileSource>$(IntellisenseXmlDir)$(AssemblyName).xml</IntellisenseXmlFileSource>
<!-- TODO: remove when we get dotnet-api-docs_netcoreapp5.0 -->
<IntellisenseXmlFileSource Condition="!Exists('$(IntellisenseXmlFileSource)')">$([System.IO.Path]::ChangeExtension('$(TargetPath)', '.xml'))</IntellisenseXmlFileSource>

<IntellisenseXml Condition="'$(ProduceReferenceAssembly)' == 'true' And '$(PackageAsRefAndLib)' != 'true'" >$([System.IO.Path]::ChangeExtension('$(TargetRefPath)', '.xml'))</IntellisenseXml>
<IntellisenseXml Condition="'$(PackageAsRefAndLib)' == 'true'" >$([System.IO.Path]::ChangeExtension('$(TargetPath)', '.xml'))</IntellisenseXml>
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.VisualBasic.Forms/src/Microsoft.VisualBasic.Forms.vbproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<RootNamespace></RootNamespace>
<LangVersion>15.0</LangVersion>
<VBRuntime>None</VBRuntime>
<ProduceReferenceAssembly>true</ProduceReferenceAssembly>
Copy link
Member

@dagood dagood Nov 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To add a little more context, this line being missing was what blocks the auto-update PR into windowsdesktop, because the ref closure is missing this dependency. The intellisense xml is a winforms repo requirement that blocked adding this line, windowsdesktop doesn't check for it.
</PropertyGroup>

<ItemGroup>
Expand Down