Skip to content

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Nov 1, 2024

This gets people into trouble since restarting the server means project information is lost when using devkit. See #5882

So disable this command when devkit is enabled

@dibarbet dibarbet requested a review from a team as a code owner November 1, 2024 23:20
@dibarbet dibarbet requested a review from arunchndr November 1, 2024 23:21
"title": "%command.dotnet.restartServer%",
"category": ".NET",
"enablement": "dotnet.server.activationContext != 'OmniSharp'"
"enablement": "dotnet.server.activationContext == 'Roslyn'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Roslyn' means standalone C#

@dibarbet dibarbet merged commit 1c7c84e into dotnet:main Nov 2, 2024
14 of 16 checks passed
@dibarbet dibarbet deleted the disable_restart_devkit branch November 2, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants