Memoize some CngKey standard properties #99053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones Issue DetailsThis memoizes some CngKey properties similar to what we did for KeySize in #89599 for performance. Accessing CNG key properties by Win32 have non-trivial performance characteristics since it results in an LRPC call. These properties are set during key creation time and cannot be changed after-the-fact, so storing them is reasonable. Closes #89821
|
ghost assigned 
stephentoub reviewed Mar 1, 2024
...s/System.Security.Cryptography/src/System/Security/Cryptography/CngKey.StandardProperties.cs Show resolved Hide resolved
This was referenced Mar 1, 2024
bartonjs reviewed Mar 5, 2024
...s/System.Security.Cryptography/src/System/Security/Cryptography/CngKey.StandardProperties.cs Outdated Show resolved Hide resolved
bartonjs reviewed Mar 5, 2024
...s/System.Security.Cryptography/src/System/Security/Cryptography/CngKey.StandardProperties.cs Outdated Show resolved Hide resolved
bartonjs approved these changes Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This memoizes some CngKey properties similar to what we did for KeySize in #89599 for performance. Accessing CNG key properties by Win32 have non-trivial performance characteristics since it results in an LRPC call. These properties are set during key creation time and cannot be changed after-the-fact, so storing them is reasonable.
Closes #89821