Skip to content

Conversation

@danmoseley
Copy link
Member

It's my understanding from https://www.unicode.org/reports/tr17 that the hyphen form is correct. So make strings and doc comments consistent.

@ghost ghost added the area-Meta label Jul 14, 2023
@ghost ghost assigned danmoseley Jul 14, 2023
@ghost
Copy link

ghost commented Jul 14, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

It's my understanding from https://www.unicode.org/reports/tr17 that the hyphen form is correct. So make strings and doc comments consistent.

Author: danmoseley
Assignees: danmoseley
Labels:

area-Meta

Milestone: -
@tannergooding
Copy link
Member

Looks like this just catches the all upper-case UTF8 to UTF-8. We still have a number of places that use other cases (such as utf8 or Utf8, same with 16) which presumably should also be fixed?
-- Notably lot more false positives due to locals with these names

@danmoseley
Copy link
Member Author

danmoseley commented Jul 14, 2023

Looks like this just catches the all upper-case UTF8 to UTF-8. We still have a number of places that use other cases (such as utf8 or Utf8, same with 16) which presumably should also be fixed?

I only looked in comments (doc comments only) and strings. Are there any there? Didn't see any. I could churn all the code but it didn't seem worth it as customers don't see it.

@danmoseley
Copy link
Member Author

test failures are surely unrelated -- ios/tvos device not connecting, etc. seems to be a number of active failures in the repo right now.

@stephentoub
Copy link
Member

These XML comments improvements won't automatically flow to the official docs. Do they need updating as well, or do they already do it the desired way?

@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

3 participants