[release/6.0] Fix QUIC ConnectionState NRE in HandleEventConnectionClose #57742
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Backport of #57655 to release/6.0
Moved ConnectionState assignment before msquic callback registration to avoid NRE in callback, in case Connection gets closed during Stream's ctor.
Fixes #55815
/cc @CarnaViire
Customer Impact
It started hurting our CI on 8/17 badly: #55815 (comment)
Testing
CI passed. No new failures in main since merging #57655 (failures in release/6.0 still happen)
The issue is race condition, hard to test in any other way.
Risk
Low, QUIC and H/3 are hidden behind AppContext switch