Fix accidental closure in Regex.Replace

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Replace.cs

@@ -174,7 +174,7 @@ private static string Replace(MatchEvaluator evaluator, Regex regex, string inpu
 
  if (!regex.RightToLeft)
  {
- regex.Run(input, startat, ref state, (ref (SegmentStringBuilder segments, MatchEvaluator evaluator, int prevat, string input, int count) state, Match match) =>
+ regex.Run(input, startat, ref state, static (ref (SegmentStringBuilder segments, MatchEvaluator evaluator, int prevat, string input, int count) state, Match match) =>
  {
  state.segments.Add(state.input.AsMemory(state.prevat, match.Index - state.prevat));
  state.prevat = match.Index + match.Length;
@@ -193,11 +193,11 @@ private static string Replace(MatchEvaluator evaluator, Regex regex, string inpu
  {
  state.prevat = input.Length;
 
- regex.Run(input, startat, ref state, (ref (SegmentStringBuilder segments, MatchEvaluator evaluator, int prevat, string input, int count) state, Match match) =>
+ regex.Run(input, startat, ref state, static (ref (SegmentStringBuilder segments, MatchEvaluator evaluator, int prevat, string input, int count) state, Match match) =>
  {
  state.segments.Add(state.input.AsMemory(match.Index + match.Length, state.prevat - match.Index - match.Length));
  state.prevat = match.Index;
- state.segments.Add(evaluator(match).AsMemory());
+ state.segments.Add(state.evaluator(match).AsMemory());
  return --state.count != 0;
  }, reuseMatchObject: false);
 

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/Regex.Split.cs

@@ -89,7 +89,7 @@ private static string[] Split(Regex regex, string input, int count, int startat)
 
  if (!regex.RightToLeft)
  {
- regex.Run(input, startat, ref state, (ref (List<string> results, int prevat, string input, int count) state, Match match) =>
+ regex.Run(input, startat, ref state, static (ref (List<string> results, int prevat, string input, int count) state, Match match) =>
  {
  state.results.Add(state.input.Substring(state.prevat, match.Index - state.prevat));
  state.prevat = match.Index + match.Length;
@@ -117,7 +117,7 @@ private static string[] Split(Regex regex, string input, int count, int startat)
  {
  state.prevat = input.Length;
 
- regex.Run(input, startat, ref state, (ref (List<string> results, int prevat, string input, int count) state, Match match) =>
+ regex.Run(input, startat, ref state, static (ref (List<string> results, int prevat, string input, int count) state, Match match) =>
  {
  state.results.Add(state.input.Substring(match.Index + match.Length, state.prevat - match.Index - match.Length));
  state.prevat = match.Index;

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCharClass.cs

@@ -547,7 +547,7 @@ public static string ConvertOldStringsToClass(string set, string category)
  strLength -= 2;
  }
 
- return string.Create(strLength, (set, category, startsWithNulls), (span, state) =>
+ return string.Create(strLength, (set, category, startsWithNulls), static (span, state) =>
  {
  int index;
 

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCompiler.cs

@@ -1368,7 +1368,7 @@ protected void GenerateFindFirstChar()
  {
  // Create a string to store the lookup table we use to find the offset.
  Debug.Assert(_boyerMoorePrefix.Pattern.Length <= char.MaxValue, "RegexBoyerMoore should have limited the size allowed.");
- string negativeLookup = string.Create(negativeRange, (thisRef: this, beforefirst), (span, state) =>
+ string negativeLookup = string.Create(negativeRange, (thisRef: this, beforefirst), static (span, state) =>
  {
  // Store the offsets into the string. RightToLeft has negative offsets, so to support it with chars (unsigned), we negate
  // the values to be stored in the string, and then at run time after looking up the offset in the string, negate it again.
@@ -5256,7 +5256,7 @@ void EmitCharInClass()
 
  // Generate the lookup table to store 128 answers as bits. We use a const string instead of a byte[] / static
  // data property because it lets IL emit handle all the details for us.
- string bitVectorString = string.Create(8, (charClass, invariant), (dest, state) => // String length is 8 chars == 16 bytes == 128 bits.
+ string bitVectorString = string.Create(8, (charClass, invariant), static (dest, state) => // String length is 8 chars == 16 bytes == 128 bits.
  {
  for (int i = 0; i < 128; i++)
  {

src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexParser.cs

@@ -2134,7 +2134,7 @@ private void AddConcatenate(int pos, int cch, bool isReplacement)
  if (cch > 1)
  {
  string str = UseOptionI() && !isReplacement ?
- string.Create(cch, (_pattern, _culture, pos, cch), (span, state) => state._pattern.AsSpan(state.pos, state.cch).ToLower(span, state._culture)) :
+ string.Create(cch, (_pattern, _culture, pos, cch), static (span, state) => state._pattern.AsSpan(state.pos, state.cch).ToLower(span, state._culture)) :
  _pattern.Substring(pos, cch);
 
  node = new RegexNode(RegexNode.Multi, _options, str);

src/libraries/System.Text.RegularExpressions/src/System/Text/SegmentStringBuilder.cs

@@ -74,7 +74,7 @@ public override string ToString()
  length += span[i].Length;
  }
 
- string result = string.Create(length, this, (dest, builder) =>
+ string result = string.Create(length, this, static (dest, builder) =>
  {
  Span<ReadOnlyMemory<char>> localSpan = builder.AsSpan();
  for (int i = 0; i < localSpan.Length; i++)