Combine free and busy register allocation #45135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot added the area-CodeGen-coreclr 
CarolEidt force-pushed the CombineAlloc branch from e6113b9 to 43b5e4b Compare 
Contributor Author
| @dotnet/jit-contrib PTAL |
danmoseley reviewed Dec 2, 2020
kunalspathak reviewed Dec 3, 2020
Contributor
kunalspathak left a comment
kunalspathak left a comment There was a problem hiding this comment.
I did the first pass and added some questions/clarifications and minor suggestions.
src/coreclr/src/jit/lsra.cpp Outdated
src/coreclr/src/jit/lsra.cpp Outdated
Contributor
There was a problem hiding this comment.
Wondering why don't we do something like else below i.e. call findAnotherHalfRegRec() instead of getSecondHalfRegRec()? Do things vary if assignedInterval's registerType == TYP_DOUBLE ?
Contributor
There was a problem hiding this comment.
The comment of this method always expect reg to be lower half: "reg" should be a even-numbered float register, i.e. lower half of double register.
Perform register allocation for a given RefPosition with a single traversal of the registers, whether free or busy.
Fix one source of arm32 double diffs.
Fix `nextPhysRefLocation` computation for Arm32
CarolEidt force-pushed the CombineAlloc branch from d7a380a to c7b8873 Compare …correctly handling doubles on ARM
am11 reviewed Dec 8, 2020
src/coreclr/tests/src/JIT/Regression/JitBlue/GitHub_13735/GitHub_13735.cs Show resolved Hide resolved
11 tasks
ghost locked as resolved and limited conversation to collaborators Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Combine register selection to consider free and busy registers in the same method.
Refactor the selection to make it easier to reorder the criteria.
Edit by @kunalspathak:
Fixes: #9399