Replace Tuples with ValueTuples #44712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas reviewed Nov 16, 2020
src/libraries/Common/src/System/Security/Cryptography/Pkcs12Kdf.cs Outdated Show resolved Hide resolved
jkotas reviewed Nov 16, 2020
.../System.Security.Cryptography.X509Certificates/src/Internal/Cryptography/Pal.OSX/ChainPal.cs Outdated Show resolved Hide resolved
jkotas approved these changes Nov 16, 2020
marek-safar reviewed Nov 16, 2020
src/libraries/System.Data.Common/src/System/Data/Common/DataStorage.cs Outdated Show resolved Hide resolved
marek-safar reviewed Nov 16, 2020
marek-safar reviewed Nov 16, 2020
marek-safar reviewed Nov 16, 2020
.../System.Security.Cryptography.Algorithms/src/Internal/Cryptography/AesImplementation.Unix.cs Outdated Show resolved Hide resolved
marek-safar approved these changes Nov 16, 2020
Some help to remove allocation, some just help to avoid pulling in Tuple and likely increasing build size.
stephentoub force-pushed the moretuple branch from 904f235 to d0ee5ef Compare 
stephentoub commented Nov 16, 2020
stephentoub commented Nov 16, 2020
.../System.Security.Cryptography.Algorithms/src/Internal/Cryptography/AesImplementation.Unix.cs Show resolved Hide resolved
bartonjs reviewed Nov 16, 2020
bartonjs approved these changes Nov 16, 2020
…f.cs Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
stephentoub added the linkable-framework 
ghost locked as resolved and limited conversation to collaborators Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some help to remove allocation, some just help to avoid pulling in Tuple and likely increasing build size.
(Remaining uses of Tuple in netcoreapp don't appear to be worthwhile changing, e.g. a reference type is needed for atomic replacement.)
cc: @jkotas, @marek-safar