Skip to content

Use Span-based CreateHMAC where possible #43541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 19, 2020
Merged

Use Span-based CreateHMAC where possible #43541

merged 2 commits into from
Oct 19, 2020

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Oct 16, 2020

Since CreateHMAC accepts a span now, use it where applicable.

PR is much easier to review when ignoring white space differences.
@ghost
Copy link

ghost commented Oct 16, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @jeffhandley
See info in area-owners.md if you want to be subscribed.
@vcsjones
Copy link
Member Author

vcsjones commented Oct 17, 2020

@bartonjs I totally spaced on the downlevel targets. I put some #ifs there to get things moving along, but, if you think the impact on code readability isn't worth it, feel free to close the PR.
stephentoub
stephentoub approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
@runfoapp runfoapp bot mentioned this pull request Oct 19, 2020
Closed
@bartonjs bartonjs merged commit ebe2a70 into dotnet:master Oct 19, 2020
@vcsjones vcsjones deleted the createhmac-span branch October 19, 2020 17:47
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Security

4 participants

@vcsjones @stephentoub @bartonjs @Dotnet-GitSync-Bot