Fix tests on macOS 26 beta 6 #118652
Merged
Fix tests on macOS 26 beta 6 #118652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates X509 certificate chain validation tests to handle changes in macOS 26 beta 6, where Apple modified their trust store behavior. The changes address two specific test failures caused by Apple removing the blocked key list and yanking an expired root certificate from their trust store.
Key changes:
- Added detection for macOS 26 or later via
IsApplePlatform26OrLaterproperty - Updated test logic to handle different chain element counts based on platform version
- Modified blocked key test to account for Apple no longer maintaining a disallowed keys list
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PlatformDetection.Unix.cs | Adds IsApplePlatform26OrLater property to detect macOS 26+ |
| ChainTests.cs | Updates two test methods to handle macOS 26+ behavioral changes in certificate chain validation |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Contributor
| Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
This was referenced Aug 12, 2025
bartonjs reviewed Aug 12, 2025
src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs Show resolved Hide resolved
bartonjs reviewed Aug 12, 2025
src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs Show resolved Hide resolved
bartonjs approved these changes Aug 13, 2025
This was referenced Aug 13, 2025
Open
This was referenced Aug 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Apple made a few changes to their trust stores in macOS 26 beta 6.
The first,
BuildChainForCertificateSignedWithDisallowedKeyis they no longer have a list of disallowed keys. Prior to macOS 26, Apple kept a list of blocked keys at /System/Library/Security/Certificates.bundle/Contents/Resources/Blocked.plist. These values in the plist were SHA-1 subjectKeyIdentifiers. This list is no longer present on macOS 26. This seems largely sensible - all of those certificates that had those subject key identifiers are distrusted by other means, such as expiration or simply no longer being present in the root store.The second,
SystemTrustCertificateWithCustomRootTrust, is failing because Apple yanked an expired root from their trust store. So it's going in to the same logical path as OpenSSL is now.Contributes to #118645
Contributes to #118646