Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 24, 2025

Backport of #113963 to release/9.0-staging

/cc @steveharter

v8 backport: #115008

Customer Impact

  • Customer reported
  • Found internally

Two recently added members are now removed from the NetStandard package so that a project targeting NetStandard will get a compile error if they try to use the members instead of a MissingMethodException if the members are called when running under .NET Framework.

Regression

  • Yes
  • No

Testing

Verified the NetStandard2.0 package does not contain:

  • LdapSessionOptions::get_TrustedCertificatesDirectory()
  • LdapSessionOptions::set_TrustedCertificatesDirectory()
  • LdapSessionOptions::StartNewTlsSessionContext()

Risk

Low. The method does not exist in the .NET Framework implementation, so we don't expose it in NetStandard.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@ghost
Copy link

ghost commented Apr 24, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. 
1 similar comment
@ghost
Copy link

ghost commented Apr 24, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. 
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

@steveharter steveharter self-assigned this Apr 24, 2025
@steveharter steveharter requested review from artl93 and ericstj April 24, 2025 20:14
@steveharter steveharter added Servicing-consider Issue for next servicing release review and removed new-api-needs-documentation labels Apr 24, 2025
@steveharter steveharter added this to the 9.0.x milestone Apr 24, 2025
@rbhanda rbhanda modified the milestones: 9.0.x, 9.0.6 Apr 29, 2025
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 29, 2025
@vseanreesermsft vseanreesermsft added Servicing-consider Issue for next servicing release review and removed Servicing-consider Issue for next servicing release review labels May 2, 2025
@steveharter
Copy link
Contributor

/ba-g unrelated System.Globalization.Tests failures

@steveharter steveharter merged commit 6b4ff8d into release/9.0-staging May 7, 2025
93 of 102 checks passed
@steveharter steveharter deleted the backport/pr-113963-to-release/9.0-staging branch May 7, 2025 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

5 participants