Skip to content

Add Regex.EnumerateSplits #103307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stephentoub merged 3 commits into from
Jun 12, 2024
Merged

Add Regex.EnumerateSplits #103307

stephentoub merged 3 commits into from
Jun 12, 2024

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Jun 11, 2024

Closes #100369
@ghost
Copy link

ghost commented Jun 11, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
@ghost
Copy link

ghost commented Jun 11, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.
This was referenced Jun 12, 2024
Closed
Closed
Open
Closed
Closed
joperezr
joperezr approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions but looks great. Thanks Steve!
@stephentoub stephentoub merged commit a08fe0f into dotnet:main Jun 12, 2024
@stephentoub stephentoub deleted the regexenumeratesplits branch June 12, 2024 16:43
@colejohnson66
Copy link
Contributor

colejohnson66 commented Jun 13, 2024

I know this is already merged, but shouldn't startat be startAt?
@stephentoub
Copy link
Member Author

stephentoub commented Jun 13, 2024

I know this is already merged, but shouldn't startat be startAt?

If we were starting from scratch, yes, but this is how all the other regex methods spell it, e.g. https://learn.microsoft.com/en-us/dotnet/api/system.text.regularexpressions.regex.match?view=net-8.0#system-text-regularexpressions-regex-match(system-string-system-int32), so we're staying consistent with that.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Text.RegularExpressions new-api-needs-documentation

4 participants

@stephentoub @colejohnson66 @danmoseley @joperezr