You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Continuation of switching off HybridGlobalization tests on v8. HybridGlobalization_AOT lane on CI was still running V8 because it was overwriting the scenarios argument passed here:
/root/helix/work/correlation/build/wasm-shared/WasmApp.Common.targets(513,5): error : Specified Emscripten sdk at $(EMSDK_PATH)=/root/helix/work/correlation/build/emsdk/ is missing some paths: $(EmscriptenNodeToolsPath)=/root/helix/work/correlation/build/emsdk/node/bin/ . SDK is required for AOT'ing assemblies.
is #51746, so we cannot enable running them yet, I will have to block HybridGlobalization_AOT till it's resolved. But generally the PR serves its purpose.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of switching off HybridGlobalization tests on v8.
HybridGlobalization_AOTlane on CI was still running V8 because it was overwriting thescenariosargument passed here:runtime/eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.yml
Line 216 in e6c2e53
Example of run with v8 on:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=702059&view=logs&j=2c5d15bf-ca52-57a8-9a4e-bb898fb954b8
Now we don't overwrite if
scenariosis already defined.