Capture ExceptionDispatchInfo in ToAsyncEnumerable #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
saul commented Mar 29, 2022
Ix.NET/Source/System.Linq.Async.Tests/System/Linq/AsyncEnumerableTests.cs Show resolved Hide resolved
| @danielcweber any chance you could do a quick review? |
| @idg10 any chance of a review here? |
idg10 reviewed Mar 30, 2023
There was a problem hiding this comment.
The basic goal seems fine, but I've got one question: is this the only place in the entire library where this is an issue, do you know?
(I've mainly been focusing on Rx so far so I'm not familiar with Ix yet. I know we have a load of places in Rx where exceptions get caught. So it surprises me to see only one.)
Ix.NET/Source/System.Linq.Async.Tests/System/Linq/AsyncEnumerableTests.cs Outdated Show resolved Hide resolved
Ix.NET/Source/System.Linq.Async.Tests/System/Linq/AsyncEnumerableTests.cs Show resolved Hide resolved
| We make extensive use of System.Reactive in our codebase and this is the only stacktrace issue we've seen. Thank you for the review - I'll work through the comments tomorrow! |
| @idg10 I believe all comments are resolved now |
idg10 approved these changes May 18, 2023
| @idg10 please can this be merged? |
| Gentle nudge @idg10 :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi
This PR fixes an issue where stacktraces of exceptions are lost in ToAsyncEnumerable. See the added test - before this PR, the
ThrowsExceptionmethod isn't mentioned in the stacktrace at all. The stacktrace only contained System.Reactive internals. This PR uses ExceptionDispatchInfo to capture the stacktrace of active exceptions (i.e. those that have been raised).Many thanks