Skip to content

Conversation

@kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Dec 10, 2025

Added the Controls.ManualTests project to the solution and updated SolutionConfigurationPlatforms and ProjectConfigurationPlatforms to include Debug/Release configurations for x64 and x86 platforms. This improves platform support and enables manual testing for controls.

Added the Controls.ManualTests project to the solution and updated SolutionConfigurationPlatforms and ProjectConfigurationPlatforms to include Debug/Release configurations for x64 and x86 platforms. This improves platform support and enables manual testing for controls.
Copilot AI review requested due to automatic review settings December 10, 2025 13:26
@github-actions
Copy link
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33094

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33094"
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 10, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the Controls.ManualTests project to the VS Code solution file and introduces x64 and x86 platform configurations across all projects. While adding the ManualTests project is a straightforward housekeeping task, the addition of x64/x86 platform configurations deviates from established patterns in other MAUI solution files.

  • Addition of Controls.ManualTests project reference at src\Controls\tests\ManualTests\Controls.ManualTests.csproj
  • Introduction of x64 and x86 platform configurations (Debug and Release) for all 107 projects in the solution
  • All new platform configurations map to "Any CPU" builds
Comment on lines +228 to +246
Debug|x64 = Debug|x64
Debug|x86 = Debug|x86
Release|Any CPU = Release|Any CPU
Release|x64 = Release|x64
Release|x86 = Release|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.Build.0 = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.ActiveCfg = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.Build.0 = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.ActiveCfg = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.Build.0 = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.ActiveCfg = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.Build.0 = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.ActiveCfg = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.Build.0 = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.ActiveCfg = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.Build.0 = Release|Any CPU
Copy link

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of x64 and x86 platform configurations to all projects in this solution is inconsistent with other MAUI solution files. The main Microsoft.Maui.sln and Microsoft.Maui-dev.sln only use "Any CPU" configurations.

For .NET MAUI projects, platform targeting is controlled through the TargetFrameworks property in the project files (e.g., net9.0-android, net9.0-ios), not through solution platform configurations. All the x64 and x86 configurations in this PR simply map to "Any CPU" builds (ActiveCfg = Debug|Any CPU), making them redundant.

Consider removing the x64 and x86 platform configurations to maintain consistency with other solution files in the repository.

Suggested change
Debug|x64 = Debug|x64
Debug|x86 = Debug|x86
Release|Any CPU = Release|Any CPU
Release|x64 = Release|x64
Release|x86 = Release|x86
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.Build.0 = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.ActiveCfg = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.Build.0 = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.ActiveCfg = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.Build.0 = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.ActiveCfg = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.Build.0 = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.ActiveCfg = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.Build.0 = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.ActiveCfg = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.Build.0 = Release|Any CPU
Release|Any CPU = Release|Any CPU
EndGlobalSection
GlobalSection(ProjectConfigurationPlatforms) = postSolution
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.Build.0 = Debug|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.ActiveCfg = Release|Any CPU
{95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.Build.0 = Release|Any CPU
Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community ✨ Community Contribution

1 participant