- Notifications
You must be signed in to change notification settings - Fork 1.9k
[Housekeeping] Add Controls.ManualTests project #33094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added the Controls.ManualTests project to the solution and updated SolutionConfigurationPlatforms and ProjectConfigurationPlatforms to include Debug/Release configurations for x64 and x86 platforms. This improves platform support and enables manual testing for controls.
| 🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33094Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33094" |
| Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the Controls.ManualTests project to the VS Code solution file and introduces x64 and x86 platform configurations across all projects. While adding the ManualTests project is a straightforward housekeeping task, the addition of x64/x86 platform configurations deviates from established patterns in other MAUI solution files.
- Addition of Controls.ManualTests project reference at
src\Controls\tests\ManualTests\Controls.ManualTests.csproj - Introduction of x64 and x86 platform configurations (Debug and Release) for all 107 projects in the solution
- All new platform configurations map to "Any CPU" builds
| Debug|x64 = Debug|x64 | ||
| Debug|x86 = Debug|x86 | ||
| Release|Any CPU = Release|Any CPU | ||
| Release|x64 = Release|x64 | ||
| Release|x86 = Release|x86 | ||
| EndGlobalSection | ||
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.ActiveCfg = Debug|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.Build.0 = Debug|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.ActiveCfg = Debug|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.Build.0 = Debug|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.ActiveCfg = Release|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.Build.0 = Release|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.ActiveCfg = Release|Any CPU | ||
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.Build.0 = Release|Any CPU |
Copilot AI Dec 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of x64 and x86 platform configurations to all projects in this solution is inconsistent with other MAUI solution files. The main Microsoft.Maui.sln and Microsoft.Maui-dev.sln only use "Any CPU" configurations.
For .NET MAUI projects, platform targeting is controlled through the TargetFrameworks property in the project files (e.g., net9.0-android, net9.0-ios), not through solution platform configurations. All the x64 and x86 configurations in this PR simply map to "Any CPU" builds (ActiveCfg = Debug|Any CPU), making them redundant.
Consider removing the x64 and x86 platform configurations to maintain consistency with other solution files in the repository.
| Debug|x64 = Debug|x64 | |
| Debug|x86 = Debug|x86 | |
| Release|Any CPU = Release|Any CPU | |
| Release|x64 = Release|x64 | |
| Release|x86 = Release|x86 | |
| EndGlobalSection | |
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.Build.0 = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.ActiveCfg = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x64.Build.0 = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.ActiveCfg = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|x86.Build.0 = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.ActiveCfg = Release|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.Build.0 = Release|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.ActiveCfg = Release|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x64.Build.0 = Release|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.ActiveCfg = Release|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|x86.Build.0 = Release|Any CPU | |
| Release|Any CPU = Release|Any CPU | |
| EndGlobalSection | |
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Debug|Any CPU.Build.0 = Debug|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.ActiveCfg = Release|Any CPU | |
| {95BA42B5-B00E-4986-B9B5-517140378452}.Release|Any CPU.Build.0 = Release|Any CPU |
Added the Controls.ManualTests project to the solution and updated SolutionConfigurationPlatforms and ProjectConfigurationPlatforms to include Debug/Release configurations for x64 and x86 platforms. This improves platform support and enables manual testing for controls.