Standardize project settings to opt-out from 'unused bindings' detection across the repo #18431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
T-Gro added the NO_RELEASE_NOTES 
|
…dotnet/fsharp into standardize-warningsNotAsErrors
abonie approved these changes Apr 16, 2025
KevinRansom approved these changes Apr 24, 2025
github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling T-Gro added a commit that referenced this pull request May 20, 2025
* Standardize project settings to opt-out from 'unused bindings' detection across the repo (#18431) * Fix PM --------- Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com> Co-authored-by: Matt Thalman <mthalman@microsoft.com> Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <codecutter@hotmail.com> Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com> Co-authored-by: Martin <29605222+Martin521@users.noreply.github.com> Co-authored-by: Jakub Majocha <1760221+majocha@users.noreply.github.com>
This was referenced May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use
<TolerateUnusedBindings>true</TolerateUnusedBindings>as an override of the default, especially in test projects.Keep erroring on unused bindings as the default option for all projects.
Avoid repetitive blocks like