[RC2 ] Apply inferred type mappings in complex type recursive equality #36839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| @roji - the cutoff for RC2 is in a few hours - why not merge to RC2? |
SamMonoRT approved these changes Sep 22, 2025
AndriySvyryd approved these changes Sep 22, 2025
SamMonoRT changed the title 
Member Author
| Ah sorry, I somehow thought that we had already branched. If this gets approved by @artl93 / @jeffschwMSFT soon I'll merge right away. |
artl93 approved these changes Sep 22, 2025
Member
artl93 left a comment
artl93 left a comment There was a problem hiding this comment.
RC2 - don't corrupt data; newer area
roji added a commit to roji/efcore that referenced this pull request Nov 16, 2025
roji added a commit that referenced this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #36837
Description
Database types weren't being correctly inferred in queries comparing complex types - see #36837 for a full description.
Customer impact
When performing queries that compare complex types, the user may get incorrect results (data corruption):
(when the type Foo contains a property that's mapped to a non-default type in the database, e.g. DateTime to SQL Server
datetime).This also blocks some mainline scenarios in 10.0 for PostgreSQL.
How found
While updating the PostgreSQL provider to use the latest EF bits.
Regression
No
Testing
Test added
Risk
Very low, targeted 2-line fix.