Skip to content

Conversation

@roji
Copy link
Member

@roji roji commented Aug 19, 2025

As part of some due diligence on Cosmos, I noticed that we're missing the overload of RRF that accepts weights (docs). The RRF function implements hybrid search, which allows combining multiple search results together, typically vector and full-text search. This is a new Ai-related feature in EF 10 that's incomplete without this.

The actual product changes are as minimal as they can be - adding an overload and a tiny fragment to translate it to NoSQL. The rest of this PR involves substantial cleanup almost exclusively on tests (but a bit on the translator as well).

/cc @artl93 @Pilchie

@roji roji added the ask-mode label Aug 19, 2025
@roji roji requested a review from a team as a code owner August 19, 2025 13:05
@roji roji changed the title Cosmos Frf overload with weights Cosmos Rrf overload with weights Aug 19, 2025
@cincuranet cincuranet requested a review from artl93 August 19, 2025 13:34
Copy link
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@roji roji merged commit eea437f into dotnet:release/10.0 Aug 19, 2025
7 checks passed
@roji roji deleted the CosmosRrfWithWeights branch August 19, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants