Skip to content

Conversation

@gewarren
Copy link
Contributor

No description provided.

VSC-Service-Account added 2 commits September 14, 2020 19:33
@gewarren
Copy link
Contributor Author

This looks good to me.

@opbld33
Copy link

opbld33 commented Sep 15, 2020

Docs Build status updates of commit da27a9d:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Security.AccessControl/RegistryAccessRule.xml ⚠️Warning View Details
xml/System.Security.AccessControl/RegistryAuditRule.xml ⚠️Warning View Details
xml/System.Security.AccessControl/RegistrySecurity.xml ⚠️Warning View Details
xml/System.Security.Permissions/CodeAccessSecurityAttribute.xml ⚠️Warning View Details
xml/System.Security.Permissions/PermissionState.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityAction.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityAttribute.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityPermissionAttribute.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityPermissionFlag.xml ⚠️Warning View Details
xml/System.Security/IPermission.xml ⚠️Warning View Details
xml/System.Security/ISecurityEncodable.xml ⚠️Warning View Details
xml/System.Security/IStackWalk.xml ⚠️Warning View Details
xml/System.Security/PermissionSet.xml ⚠️Warning View Details
xml/System.Security/SecurityElement.xml ⚠️Warning View Details
xml/FrameworksIndex/dotnet-plat-ext-5.0.xml ✅Succeeded
xml/FrameworksIndex/net-5.0.xml ✅Succeeded
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceProviderServiceExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/ConsoleLoggerOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/LoggerColorBehavior.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.Console/SimpleConsoleFormatterOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ConsoleLoggerExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/LoggerMessage.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsFactory`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsMonitorCache`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsMonitor`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsSnapshot`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/Options.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsCache`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsFactory`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsManager`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsMonitorExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsMonitor`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsWrapper`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Primitives/InplaceStringBuilder.xml ✅Succeeded View
xml/Microsoft.VisualBasic.CompilerServices/Conversions.xml ✅Succeeded View
xml/Microsoft.VisualBasic/DateAndTime.xml ✅Succeeded View
xml/Microsoft.VisualBasic/FileSystem.xml ✅Succeeded View
xml/Microsoft.VisualBasic/Interaction.xml ✅Succeeded View
xml/Microsoft.VisualBasic/Strings.xml ✅Succeeded View
xml/System.Buffers/ReadOnlySequence`1.xml ✅Succeeded View
xml/System.Buffers/SequenceReader`1.xml ✅Succeeded View
xml/System.CodeDom.Compiler/CodeDomProvider.xml ✅Succeeded View
xml/System.CodeDom.Compiler/CodeGenerator.xml ✅Succeeded View
xml/System.Collections.Concurrent/BlockingCollection`1.xml ✅Succeeded View
xml/System.Collections.Generic/CollectionExtensions.xml ✅Succeeded View
xml/System.Collections.Generic/List`1.xml ✅Succeeded View
xml/System.Collections.Generic/SortedSet`1.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.

xml/System.Security.AccessControl/RegistryAccessRule.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.AccessControl.RegistryAccessRule's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.AccessControl/RegistryAuditRule.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.AccessControl.RegistryAuditRule's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.AccessControl/RegistrySecurity.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.AccessControl.RegistrySecurity's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/CodeAccessSecurityAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/PermissionState.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.PermissionState's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.PermissionState's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.PermissionState's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityAction.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityPermissionAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityPermissionFlag.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/IPermission.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/ISecurityEncodable.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/IStackWalk.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IStackWalk's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IStackWalk's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IStackWalk's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/PermissionSet.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.PermissionSet's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.PermissionSet's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.PermissionSet's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/SecurityElement.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-5.0 can't match any assembly.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as well @gewarren

Once @safern approves, we can :shipit:

@gewarren
Copy link
Contributor Author

Ping @safern.

@gewarren gewarren merged commit 7255cf3 into master Sep 16, 2020
@gewarren gewarren deleted the net5-rc1 branch September 16, 2020 16:33
@eiriktsarpalis eiriktsarpalis added area-System.Security Issues related to security practices for .NET developers. area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. and removed area-System.Security Issues related to security practices for .NET developers. labels Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

6 participants