Skip to content

.NET 5 Preview 8 APIs #4744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2020
Merged

.NET 5 Preview 8 APIs #4744

merged 1 commit into from
Sep 1, 2020

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented Aug 29, 2020

2nd CI build.

/cc @safern @carlossanlop
@BillWagner BillWagner requested review from gewarren and mairaw August 29, 2020 21:42
@opbld32
Copy link

opbld32 commented Aug 29, 2020

Docs Build status updates of commit e825a19:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Data.SqlTypes/SqlBytes.xml ⚠️Warning View Details
xml/System.Data.SqlTypes/SqlChars.xml ⚠️Warning View Details
xml/System.Security.Permissions/CodeAccessSecurityAttribute.xml ⚠️Warning View Details
xml/System.Security.Permissions/PermissionState.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityAction.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityAttribute.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityPermissionAttribute.xml ⚠️Warning View Details
xml/System.Security.Permissions/SecurityPermissionFlag.xml ⚠️Warning View Details
xml/System.Security/IPermission.xml ⚠️Warning View Details
xml/System.Security/ISecurityEncodable.xml ⚠️Warning View Details
xml/System.Security/IStackWalk.xml ⚠️Warning View Details
xml/System.Security/PermissionSet.xml ⚠️Warning View Details
xml/System.Security/SecurityElement.xml ⚠️Warning View Details
xml/System.Windows.Forms/AccessibleObject.xml ⚠️Warning View Details
xml/FrameworksIndex/dotnet-plat-ext-5.0.xml ✅Succeeded
xml/FrameworksIndex/net-5.0.xml ✅Succeeded
xml/Microsoft.Build.Framework/SdkResult.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/Hash.xml ✅Succeeded View
xml/Microsoft.CSharp.RuntimeBinder/Binder.xml ✅Succeeded View
xml/Microsoft.CSharp.RuntimeBinder/CSharpArgumentInfo.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/HttpClientBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/HttpClientFactoryServiceCollectionExtensions.xml ✅Succeeded View
xml/System.Buffers/SequenceReader`1.xml ✅Succeeded View
xml/System.Collections.Generic/IReadOnlySet`1.xml ✅Succeeded View
xml/System.Collections.Generic/LinkedListNode`1.xml ✅Succeeded View
xml/System.Collections.ObjectModel/ObservableCollection`1.xml ✅Succeeded View
xml/System.Collections.ObjectModel/ReadOnlyObservableCollection`1.xml ✅Succeeded View
xml/System.Collections.Specialized/CollectionChangedEventManager.xml ✅Succeeded View
xml/System.Collections.Specialized/INotifyCollectionChanged.xml ✅Succeeded View
xml/System.Collections.Specialized/NotifyCollectionChangedAction.xml ✅Succeeded View
xml/System.Collections.Specialized/NotifyCollectionChangedEventArgs.xml ✅Succeeded View
xml/System.Collections.Specialized/NotifyCollectionChangedEventHandler.xml ✅Succeeded View
xml/System.ComponentModel/CurrentChangedEventManager.xml ✅Succeeded View
xml/System.ComponentModel/CurrentChangingEventManager.xml ✅Succeeded View
xml/System.ComponentModel/DependencyPropertyDescriptor.xml ✅Succeeded View
xml/System.ComponentModel/GroupDescription.xml ✅Succeeded View
xml/System.ComponentModel/PropertyChangedEventManager.xml ✅Succeeded View
xml/System.ComponentModel/SortDescriptionCollection.xml ✅Succeeded View
xml/System.Data.Common/DataAdapter.xml ✅Succeeded View
xml/System.Data.Common/DataColumnMapping.xml ✅Succeeded View
xml/System.Data.Common/DataColumnMappingCollection.xml ✅Succeeded View
xml/System.Data.Common/DataTableMapping.xml ✅Succeeded View
xml/System.Data.Common/DataTableMappingCollection.xml ✅Succeeded View
xml/System.Data.Common/DbColumn.xml ✅Succeeded View
xml/System.Data.Common/DbCommand.xml ✅Succeeded View
xml/System.Data.Common/DbCommandBuilder.xml ✅Succeeded View
xml/System.Data.Common/DbConnection.xml ✅Succeeded View
xml/System.Data.Common/DbConnectionStringBuilder.xml ✅Succeeded View
xml/System.Data.Common/DbDataAdapter.xml ✅Succeeded View
xml/System.Data.Common/DbDataReader.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.

xml/System.Data.SqlTypes/SqlBytes.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlBytes's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlBytes's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlBytes's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlBytes's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlBytes's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Data.SqlTypes/SqlChars.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlChars's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlChars's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlChars's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlChars's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Data.SqlTypes.SqlChars's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/CodeAccessSecurityAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.CodeAccessSecurityAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/PermissionState.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.PermissionState's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.PermissionState's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.PermissionState's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityAction.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAction's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityPermissionAttribute.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionAttribute's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security.Permissions/SecurityPermissionFlag.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.Permissions.SecurityPermissionFlag's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/IPermission.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IPermission's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/ISecurityEncodable.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.ISecurityEncodable's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/IStackWalk.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IStackWalk's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IStackWalk's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.IStackWalk's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/PermissionSet.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.PermissionSet's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.PermissionSet's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.PermissionSet's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Security/SecurityElement.xml

  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-2.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-2.2 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-3.0 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-3.1 can't match any assembly.
  • Line 0, Column 0: [Warning-ECMA2Yaml_UidAssembly_NotMatched] System.Security.SecurityElement's moniker dotnet-plat-ext-5.0 can't match any assembly.

xml/System.Windows.Forms/AccessibleObject.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accKeyboardShortcut(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accChild(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accName(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.set_accValue(System.Object,System.String)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accDefaultAction(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accHelp(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accRole(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accValue(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.set_accName(System.Object,System.String)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accState(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accDescription(System.Object)'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Accessibility.IAccessible.get_accHelpTopic(System.String@,System.Object)'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:
@gewarren
Copy link
Contributor

gewarren commented Aug 31, 2020

Do we know why new build warnings are introduced?
mairaw
mairaw approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - scanned the PR and didn't see anything outstanding. Not sure why we have the extra warnings. Not sure which ones are the new ones as well.
@BillWagner BillWagner merged commit 43f0184 into master Sep 1, 2020
@BillWagner BillWagner deleted the net5-preview8 branch September 1, 2020 00:09
@BillWagner
Copy link
Member Author

BillWagner commented Sep 1, 2020

Thanks all. I'll update the monikers when I merge to live tomorrow morning.
This was referenced Sep 1, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@BillWagner @opbld32 @gewarren @carlossanlop @mairaw