Skip to content

CI Update: Add MSBuild APIs #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2020
Merged

CI Update: Add MSBuild APIs #4259

merged 2 commits into from
May 28, 2020

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented May 19, 2020

tagging @ghogen

This has the updated binaries for MS Build.
@dotnet-bot dotnet-bot added this to the May 2020 milestone May 19, 2020
@BillWagner BillWagner requested a review from ghogen May 19, 2020 22:12
@BillWagner BillWagner marked this pull request as draft May 20, 2020 11:54
@BillWagner BillWagner marked this pull request as ready for review May 27, 2020 20:04
@BillWagner
Copy link
Member Author

BillWagner commented May 27, 2020

closing and reopening for a fresh build.
@BillWagner BillWagner closed this May 27, 2020
@BillWagner BillWagner reopened this May 27, 2020
IEvangelist
IEvangelist approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, :shipit: when you're ready.
@BillWagner
Copy link
Member Author

BillWagner commented May 28, 2020

Merging so we can unblock updated mdoc fixes
@BillWagner BillWagner merged commit 496c401 into master May 28, 2020
@BillWagner BillWagner deleted the smoke-test branch May 28, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@BillWagner @IEvangelist @dotnet-bot