Skip to content

Conversation

@BillWagner
Copy link
Member

@BillWagner BillWagner commented May 13, 2020

Internal review link for the System namespace

@dotnet-bot dotnet-bot added this to the May 2020 milestone May 13, 2020
@BillWagner
Copy link
Member Author

Notes on warnings:

  • ECMA2Yaml_UidAssembly_NotMatched: This is an engineering issue, and is accepted as a bug. We expect a fix in an upcoming sprint.
  • ECMA2Yaml_MemberNameAndSignature_NotUnique: This is also an engineering issue.
  • UidNotFound: Some of these are external, and filter out polly and redis #4218 filters them out. Some of the others should be removed from the binaries repo. I'm working with the team on those, but it will probably be preview 5 before they are addressed. Others may also be filtered out once we have more feedback from the product team.
@BillWagner BillWagner requested a review from a team May 14, 2020 15:10
@Thraka
Copy link
Contributor

Thraka commented May 14, 2020

How do I review this? lol

@mairaw
Copy link
Contributor

mairaw commented May 14, 2020

Usually I start with one link and then navigate through some of the changes. Usually I scanned the diff to see if the changes I was seeing were expected more than looking at the review site.

@gewarren
Copy link
Contributor

According to @RussKie there should be a TaskDialog API, but I'm not seeing it. I only see a .NET 5.0 Preview 1 moniker?

@mairaw
Copy link
Contributor

mairaw commented May 14, 2020

The moniker description is only changed when the content goes live.

@gewarren
Copy link
Contributor

The moniker description is only changed when the content goes live.

The preview 3 content went live yesterday, but that moniker doesn't show up either.

https://docs.microsoft.com/en-us/dotnet/api/system.string?view=net-5.0

@BillWagner
Copy link
Member Author

The TaskDialog class is in this PR.

What will happen is the content goes live once we merge this (and merge to live, and it builds). The moniker description (changing to Preview 4) is done in the portal.

During the previews, we'll reuse one moniker, and only have the latest version live.

Thanks for the reminder @gewarren I just edited the current moniker to "Preview 3"

@Thraka
Copy link
Contributor

Thraka commented May 15, 2020

I did notice (even on the published site) that the platform extensions list .net 5 preview 1 only. I think that is incorrect. I would assume these APIs work on all .NET Core versions too, which means the platform extensions should have more than a single entry.

https://review.docs.microsoft.com/en-us/dotnet/api/system.windows.forms.control.createcontrol?view=net-5.0&branch=pr-en-us-4229#System_Windows_Forms_Control_CreateControl

@BillWagner
Copy link
Member Author

ping @mairaw for insight on the preview comment.

@mairaw
Copy link
Contributor

mairaw commented May 15, 2020

We didn't have System.Windows.Forms.dll as part of the extensions set before.

@mairaw
Copy link
Contributor

mairaw commented May 15, 2020

And API Catalog only shows that as part of 3.0 (I guess we moved to shared framework instead for docs): https://apisof.net/catalog/System.Windows.Forms.Control.CreateControl()

/cc @safern

@BillWagner BillWagner merged commit 9a8ca60 into master May 19, 2020
@BillWagner BillWagner deleted the smoke-test branch May 19, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants