Skip to content

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Feb 25, 2020

These were the only undocumented APIs in System.IO, introduced in 1.x. They had no triple slash comments.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Feb 25, 2020
@carlossanlop carlossanlop added this to the February 2020 milestone Feb 25, 2020
@carlossanlop carlossanlop requested review from a team, JeremyKuhne and jozkee February 25, 2020 08:43
@carlossanlop carlossanlop self-assigned this Feb 25, 2020
@carlossanlop carlossanlop changed the title Document System.IO.PipesAclExtensions System.IO 1.x undocumented APIs - System.IO.PipesAclExtensions Feb 25, 2020
@carlossanlop carlossanlop changed the title System.IO 1.x undocumented APIs - System.IO.PipesAclExtensions System.IO 1.x undocumented APIs Feb 25, 2020
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @carlossanlop

I'll :shipit: now.

@BillWagner BillWagner merged commit f7a58a3 into dotnet:master Feb 26, 2020
@carlossanlop carlossanlop deleted the PipesAclExtensions branch February 26, 2020 18:31
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Feb 27, 2020
@mairaw mairaw mentioned this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-content Indicates PRs that contain new articles

3 participants