Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Oct 26, 2019

Summary

The description was using assembly "loading" and "binding" interchangeably. Standardize on "loading" to avoid confusion.

This class is not abstract anymore starting with .NET Core 3.0
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM as well. I'll :shipit: now.

@BillWagner BillWagner merged commit 1ab7e70 into master Oct 28, 2019
@BillWagner BillWagner deleted the jkotas-patch-1-1 branch October 28, 2019 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants