- Notifications
You must be signed in to change notification settings - Fork 6.1k
Add libatomic1 to Ubuntu Dependencies #49727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds libatomic1 as a required dependency for Ubuntu 25.10 in the .NET installation documentation. The change aligns the documentation with the actual SDK Docker image requirements, ensuring users who manually install .NET or publish self-contained apps are aware of this dependency.
Key changes:
- Added
libatomic1to the Ubuntu 25.10 dependencies list in the installation documentation.
Comments suppressed due to low confidence (3)
docs/core/install/linux-ubuntu-install.md:120
- The
libatomic1dependency should also be added to the Ubuntu 25.04 dependencies list (around line 112) for consistency. According to the PR description,libatomic1is required by the SDK Docker image, and this requirement likely applies to all recent Ubuntu versions, not just 25.10.
- ca-certificates - libc6 - libgcc-s1 - libgssapi-krb5-2 - libicu76 - libssl3t64 - libstdc++6 - tzdata - zlib1g docs/core/install/linux-ubuntu-install.md:176
- The
libatomic1dependency should also be added to the Ubuntu 24.04 dependencies list (around line 168) for consistency. Since the SDK Docker image explicitly requireslibatomic1, this dependency should be documented for all supported Ubuntu versions.
- ca-certificates - libc6 - libgcc-s1 - libgssapi-krb5-2 - libicu74 - libssl3t64 - libstdc++6 - tzdata - zlib1g docs/core/install/linux-ubuntu-install.md:234
- The
libatomic1dependency should also be added to the Ubuntu 22.04 dependencies list (around line 226) for consistency. The Docker image requirement forlibatomic1likely applies to this version as well, ensuring accurate documentation for manual installations and self-contained app deployments.
- ca-certificates - libc6 - libgcc-s1 - libgssapi-krb5-2 - libicu70 - libssl3 - libstdc++6 - tzdata - zlib1g | Thanks for noticing and fixing this. I have a query open to the product team to validate this (on either the Dockerfile or the backing requirements.json file for .NET) |
| @Cryptoc1 I think the discussion I'm seeing is that this lib is very useful for developer scenarios, but it's not specifically a dependency. |
| @adegeo would it make sense to have separate "SDK Dependencies" and "Runtime Dependencies" lists? |
| I don't think so. It's not a dependency either way. However, this is the list of dependencies and I would say if this list gets the package, it makes sense to update the docs to follow: https://github.com/dotnet/core/blob/main/release-notes/10.0/os-packages.json |
| @adegeo I'm not quite following... Per Sdk#51677, if a command like |
| Ahhhhh I see, thank you for clarifying. @leecow @richlander Should we add this to the dependencies json if it's required for the SDK? Or are we really only documenting the runtime-only dependencies? |
| I'm not sure I understand the |
| I thought this library was a dependency on libmsquic so only relevant for HTTP/3 scenario. Is that true? |
| Here is example output of the error (which occurred when building/publishing a BlazorWASM project): It appears that |
Summary
libatomic1is a dependency that is explicitly installed in the sdk docker image, but is not specified as a dependency in the documentation, leading to unexpected behavior for users who perform manual/scripted installation of sdks.Fixes: Sdk#51677
Internal previews