Fix build warnings #45942
Merged
Fix build warnings #45942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This reverts commit 336de02.
gewarren requested review from a team, BillWagner, CamSoper, HongGit, IEvangelist, KathleenDollard, adegeo, alexwolfmsft and nishanil as code owners 
dotnet-policy-service bot added dotnet-architecture/svc cloud-native/subsvc microservices/subsvc dotnet-azure/svc dotnet-fundamentals/svc dotnet-csharp/svc whats-new/subsvc dotnet-framework/svc install/subsvc dotnet-wcf/subsvc dotnet-fsharp/svc dotnet-data/svc okr-quality 
T-Gro approved these changes Apr 29, 2025
Copilot AI added a commit that referenced this pull request Nov 4, 2025
The note incorrectly stated that TargetFrameworks property is ignored if TargetFramework is specified. The actual behavior is the opposite - when both properties are present, TargetFrameworks (plural) takes precedence and TargetFramework (singular) is ignored. Updated the note to correctly reflect this behavior. Fixes #45942 Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
gewarren added a commit that referenced this pull request Nov 4, 2025
) * Initial plan * Fix TargetFrameworks documentation note The note incorrectly stated that TargetFrameworks property is ignored if TargetFramework is specified. The actual behavior is the opposite - when both properties are present, TargetFrameworks (plural) takes precedence and TargetFramework (singular) is ignored. Updated the note to correctly reflect this behavior. Fixes #45942 Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: gewarren <24882762+gewarren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Contributes to #44218.
(Hide whitespace changes.)
Internal previews
Toggle expand/collapse