Remove a small allocation in MethodBase.ToString()

[EgorBo]

Don't call base.ToString() and Substring if the type is void (the most popular return type I guess).

MethodInfo method = typeof(Program).GetMethod("Main"); long a = GC.GetAllocatedBytesForCurrentThread(); string str = method.ToString(); // "Void Main(System.String[])" long b = GC.GetAllocatedBytesForCurrentThread(); Console.WriteLine((b - a) + " bytes");

Before: 3792 bytes
After: 3592 bytes

I know the ToString() for methods is cached so this optimization affects only first calls of methodBase.ToString().

[MichalStrehovsky]

Why not just make the primitives, void, etc. take the IsNested path that just returns the Name? We could get rid of the Substring completely.

[EgorBo]

@MichalStrehovsky oh, indeed, however maybe it make sense to keep that fast path for "Void"?

[EgorBo]

Moved to the shared partitions in order to re-use it from Mono
AppendParameters is untouched.

[stephentoub]

however maybe it make sense to keep that fast path for "Void"?

Why?

[EgorBo]

Removed fast path for void.

[jkotas]

@EgorBo Could you please resolve the conflict?

[EgorBo]

@jkotas oh, sure!