- Notifications
You must be signed in to change notification settings - Fork 10.5k
Revert log level severity for unknown proxy in ForwardedHeadersMiddleware #64090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts the log level for unknown proxy detection in ForwardedHeadersMiddleware from Warning back to Debug. The previous change to Warning level was causing excessive log noise for customers in legitimate proxy scenarios where unknown IP addresses are expected.
- Reduces log level from Warning to Debug for unknown proxy detection
- Addresses customer complaints about excessive warning logs in valid proxy configurations
wtgodbe approved these changes Oct 17, 2025
wtgodbe approved these changes Oct 17, 2025
joperezr approved these changes Oct 17, 2025
This was referenced Nov 11, 2025
Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.21 to 8.0.22 TechnologyEnhancedLearning/TELBlazor#333
Merged
This was referenced Nov 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Revert logging severity in ForwardedHeaders middleware
Description
As part of strengthening our security posture in the ForwardedHeaders middleware we increased the severity of a log from
DebugtoWarninghoping to give consumers a more obvious signal that unexpected requests were hitting their application.Unfortunately, that change doesn't have the intended effect as it's not uncommon to receive valid requests that have unknown IP addresses in the forwarded headers. e.g. In a proxy scenario where the proxy isn't hosted in a well-defined IP range, or a request goes through many proxy layers and the application is only aware of the last layer, etc.
Customer Impact
Customers are receiving lots of Warning logs, which may trigger telemetry checks, unexpectedly increase log storage size, etc.
Regression?
Change was intended as a signal that unexpected requests were being received, which isn't really accurate in real apps.
Risk
Just changing a log level to what it was before.
Verification
Packaging changes reviewed?