Fix UserStore passkey name update #63981
Open
+401 −87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the ASP.NET Core Identity UserStore where passkey name updates were not being persisted after initial creation. The fix ensures that both UserStore and UserOnlyStore implementations have consistent behavior when updating passkey properties.
- Adds missing
userPasskey.Data.Name = passkey.Nameassignment inUserStore.AddOrUpdatePasskeyAsync - Updates test configurations to use Identity schema version 3 to enable passkey functionality
- Adds comprehensive test coverage for passkey operations including name updates
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Identity/EntityFrameworkCore/src/UserStore.cs | Fixes the missing passkey name update and adds null check for credentialId parameter |
| src/Identity/EntityFrameworkCore/src/UserOnlyStore.cs | Adds null check for credentialId parameter for consistency |
| src/Identity/Specification.Tests/src/IdentitySpecificationTestBase.cs | Enables schema version 3 and adds comprehensive passkey test coverage |
| src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs | Enables schema version 3 for passkey support |
| src/Identity/EntityFrameworkCore/test/EF.Test/UserStoreTest.cs | Updates test configuration and removes unnecessary blank line |
| src/Identity/EntityFrameworkCore/test/EF.Test/UserStoreWithGenericsTest.cs | Configures schema version 3 for testing |
| src/Identity/EntityFrameworkCore/test/EF.Test/UserStoreEncryptPersonalDataTest.cs | Enables schema version 3 |
| src/Identity/EntityFrameworkCore/test/EF.Test/SqlStoreTestBase.cs | Configures schema version 3 for tests |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where
UserStoredoesn't apply updates to a passkey's name after its initial creation.Details
The issue was only present in
UserStore, asUserOnlyStorewas already implemented correctly. I've added extra tests to protected against similar implementation inconsistencies.Fixes #63923