Fix attribute order dependency in ModelAttributesTest #62909
Merged
+2 −4
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes a test failure on Mono runtime by removing dependency on attribute ordering in ModelAttributesTest.GetAttributesForParameter_SomeAttributes
Description
The test was failing on Mono runtime because it assumed
SerializableAttribute
would be the first attribute returned byGetCustomAttributes()
see detail here
As pointed out by @jkotas in dotnet/runtime#117864:
The C# Specification confirms that attribute order is not guaranteed
This change ensures the test verifies the presence of the expected attribute without depending on its position, making it compliant with the C# specification and compatible across all .NET runtimes.
cc: @jkotas