Don't error on Protobuf messages that expose wrapper types #62871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Protobuf wrapper types in gRPC JSON transcoding by implementing conversion logic to handle scenarios where wrapper types are directly exposed on DTOs rather than their underlying primitive types.
- Adds detection and conversion logic for wrapper types (StringValue, Int32Value, etc.) in the JSON transcoding infrastructure
- Includes new test coverage for reading and writing JSON with wrapper type properties
- Adds a generated WrappersMessage test class to support the new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| WrappersMessage.cs | Generated Protobuf message class containing all wrapper types for testing |
| JsonConverterWriteTests.cs | Adds test for serializing wrapper types to JSON |
| JsonConverterReadTests.cs | Adds test for deserializing JSON to wrapper types |
| MessageTypeInfoResolver.cs | Core implementation for detecting and converting wrapper types during serialization/deserialization |
...rosoft.AspNetCore.Grpc.JsonTranscoding.Tests/TestObjects/ProtobutMessages/WrappersMessage.cs Outdated Show resolved Hide resolved
...oding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/Json/MessageTypeInfoResolver.cs Outdated Show resolved Hide resolved
...oding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/Json/MessageTypeInfoResolver.cs Show resolved Hide resolved
...oding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/Json/MessageTypeInfoResolver.cs Show resolved Hide resolved
captainsafia approved these changes Jul 23, 2025
| /azp run |
| Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #55254
Add logic to convert to and from wrapper types when they're exposed on Protobuf DTOs.
Note that the Protobuf DTO class is added directly instead of code genned. This is done because code gen in this project wouldn't expose the wrapper types.