Skip to content

[blazor] diagnostics - feedback for code.function.name #62836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

[blazor] diagnostics - feedback for code.function.name #62836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Components/Components/src/ComponentsActivitySource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ public static ComponentsActivityHandle StartHandleEventActivity(string? componen
}
if (methodName != null)
{
activity.SetTag("aspnetcore.components.method", methodName);
activity.SetTag("code.function.name", methodName);
}
if (attributeName != null)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Components/Components/src/ComponentsMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public async Task CaptureEventDuration(Task task, long startTimestamp, string? c
var tags = new TagList
{
{ "aspnetcore.components.type", componentType ?? "unknown" },
{ "aspnetcore.components.method", methodName ?? "unknown" },
{ "code.function.name", methodName ?? "unknown" },
{ "aspnetcore.components.attribute.name", attributeName ?? "unknown" }
};

Expand All @@ -104,7 +104,7 @@ public void FailEventSync(Exception ex, long startTimestamp, string? componentTy
var tags = new TagList
{
{ "aspnetcore.components.type", componentType ?? "unknown" },
{ "aspnetcore.components.method", methodName ?? "unknown" },
{ "code.function.name", methodName ?? "unknown" },
{ "aspnetcore.components.attribute.name", attributeName ?? "unknown" },
{ "error.type", ex.GetType().FullName ?? "unknown" }
};
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Components/test/ComponentsActivitySourceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public void StartEventActivity_CreatesAndStartsActivity()
Assert.Equal(ActivityKind.Internal, activity.Kind);
Assert.True(activity.IsAllDataRequested);
Assert.Equal(componentType, activity.GetTagItem("aspnetcore.components.type"));
Assert.Equal(methodName, activity.GetTagItem("aspnetcore.components.method"));
Assert.Equal(methodName, activity.GetTagItem("code.function.name"));
Assert.Equal(attributeName, activity.GetTagItem("aspnetcore.components.attribute.name"));
Assert.False(activity.IsStopped);

Expand Down
8 changes: 4 additions & 4 deletions src/Components/Components/test/ComponentsMetricsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ await componentsMetrics.CaptureEventDuration(Task.CompletedTask, startTimestamp,
Assert.Single(measurements);
Assert.True(measurements[0].Value > 0);
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", measurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", measurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("code.function.name", measurements[0].Tags));
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", measurements[0].Tags));
Assert.DoesNotContain("error.type", measurements[0].Tags);
}
Expand All @@ -112,7 +112,7 @@ await componentsMetrics.CaptureEventDuration(Task.FromException(new InvalidOpera
Assert.Single(measurements);
Assert.True(measurements[0].Value > 0);
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", measurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", measurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("code.function.name", measurements[0].Tags));
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", measurements[0].Tags));
Assert.Equal("System.InvalidOperationException", Assert.Contains("error.type", measurements[0].Tags));
}
Expand All @@ -137,7 +137,7 @@ public void FailEventSync_RecordsErrorMetric()
Assert.Single(measurements);
Assert.True(measurements[0].Value > 0);
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", measurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", measurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("code.function.name", measurements[0].Tags));
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", measurements[0].Tags));
Assert.Equal("System.InvalidOperationException", Assert.Contains("error.type", measurements[0].Tags));
}
Expand Down Expand Up @@ -372,7 +372,7 @@ await componentsMetrics.CaptureEventDuration(Task.CompletedTask, startTimestamp2
// Check event duration
Assert.True(eventMeasurements[0].Value > 0);
Assert.Equal("TestComponent", Assert.Contains("aspnetcore.components.type", eventMeasurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("aspnetcore.components.method", eventMeasurements[0].Tags));
Assert.Equal("OnClick", Assert.Contains("code.function.name", eventMeasurements[0].Tags));
Assert.Equal("onclick", Assert.Contains("aspnetcore.components.attribute.name", eventMeasurements[0].Tags));

// Check parameters duration
Expand Down
Loading