OwningComponentBase implements IAsyncDisposable #62583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dotnet-policy-service bot added the community-contribution 
ilonatommy reviewed Jul 7, 2025
ilonatommy added the breaking-change dotnet-policy-service bot added the needs-breaking-change-announcement 
| @dotnet-policy-service agree |
ilonatommy removed the community-contribution Reverted one change
javiercn reviewed Jul 7, 2025
javiercn reviewed Jul 7, 2025
Removed `OwningComponentBase.DisposeAsync()` from the PublicAPI as the implementation is private now
javiercn reviewed Jul 7, 2025
javiercn reviewed Jul 7, 2025
javiercn reviewed Jul 7, 2025
| /ba-g failure connected with known issue |
sins921 approved these changes Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
OwningComponentBase implements IAsyncDisposable
Description
This pull request enhances the
OwningComponentBaseclass by adding support for asynchronous disposal, improving resource management, and updating tests to validate the new functionality. The most important changes include implementing theIAsyncDisposableinterface, adding new methods for asynchronous disposal, updating the public API, and introducing new test cases to ensure proper behavior.Enhancements to
OwningComponentBase:src/Components/Components/src/OwningComponentBase.cs: Updated theOwningComponentBaseclass to implement theIAsyncDisposableinterface. AddedDisposeAsync,DisposeAsyncCore, and updated theDisposemethod to handle both synchronous and asynchronous disposal of the service scope.Public API updates:
src/Components/Components/src/PublicAPI.Unshipped.txt: AddedDisposeAsyncandDisposeAsyncCoremethods to the public API to reflect the new asynchronous disposal capabilities.Testing improvements:
src/Components/Components/test/OwningComponentBaseTest.cs: Added new test cases to verify the behavior ofDisposeAsync, ensure that accessing scoped services after disposal throws an exception.Fixes #25873