Fix handling of implicitly declared EqualityContract on record types in validation generator #62511
Conversation
…in validation generator Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
Copilot AI changed the title | | ||
| } | ||
| | ||
| [Fact] |
There was a problem hiding this comment.
Removed the test as requested. a6e7085
| @@ -0,0 +1,160 @@ | |||
| //HintName: ValidatableInfoResolver.g.cs | |||
There was a problem hiding this comment.
Removed the snapshot file as requested. a6e7085
| return true; | ||
| } | ||
| | ||
| private static bool IsEqualityContract(IPropertySymbol prop) => |
There was a problem hiding this comment.
Move this method to src/Validation/gen/Extensions/ISymbolExtensions.cs.
There was a problem hiding this comment.
Moved the method to ISymbolExtensions.cs as requested and updated it to use WellKnownTypes for type comparison. a6e7085
| | ||
| private static bool IsEqualityContract(IPropertySymbol prop) => | ||
| prop.Name == "EqualityContract" | ||
| && prop.Type.ToDisplayString() == "System.Type" |
There was a problem hiding this comment.
Add System.Type to https://github.com/dotnet/aspnetcore/blob/main/src/Shared/RoslynUtils/WellKnownTypeData.cs then use WellKnownTypes to do the type comparison here.
There was a problem hiding this comment.
Added System.Type to WellKnownTypeData.cs and updated the method to use WellKnownTypes for type comparison instead of string comparison. a6e7085
…sions and use WellKnownTypes Co-authored-by: captainsafia <1857993+captainsafia@users.noreply.github.com>
3 participants
When a record class being inspected comes from metadata (i.e., a referenced assembly or a prior incremental step), its compiler-synthesized
EqualityContractproperty is not flagged withIsImplicitlyDeclared == true. The current filter inExtractValidatableMembersrelies solely on that flag, so the property slips through and aGeneratedValidatablePropertyInfois produced for it.As a result, every metadata-based record type ends up with a spurious
ValidatablePropertyInfoforEqualityContractwhich the runtime resolver will attempt to apply and fail for.Changes Made
This PR adds a helper method that recognizes
EqualityContractby its signature, not just byIsImplicitlyDeclared, and uses it in the skip logic:The member filtering loop is updated to use this helper:
Testing
Added a specific test
RecordTypes_DoNotIncludeEqualityContractPropertythat verifies record types from metadata don't incorrectly include theEqualityContractproperty in generated validation info. The test shows that only the actual record properties (likeNamewith[Required]) are included, not the compiler-generatedEqualityContract.All existing tests continue to pass, ensuring no regressions.
Fixes #62510.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.