Improve support for methods with multiple JSInvokable attributes #59787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ttps://github.com/rsandbach/aspnetcore into improve-support-for-multiple-JSInvokable-attributes
ghost added the 
dotnet-policy-service bot added the community-contribution dotnet-policy-service bot added the pending-ci-rerun 
javiercn approved these changes Jan 20, 2025
Member
| /azp run aspnetcore-ci |
| Azure Pipelines successfully started running 1 pipeline(s). |
javiercn removed the pending-ci-rerun 
Member
| Thank you for resolving this! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Improve support for methods with multiple JSInvokable attributes
Change
ScanAssemblyForCallableMethodsandScanTypeForCallableMethodsto callGetCustomAttribute_s_instead ofGetCustomAttribute. Add all the defined identifiers as opposed to crashing on an unhandled AmbiguousMatchException.Description
Fixes #54646