Skip to content

Suppress ExecutionContext flow in SocketAwaitableEventArgs #18398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

Suppress ExecutionContext flow in SocketAwaitableEventArgs #18398

merged 1 commit into from
Jan 28, 2020

Conversation

@benaadams
Copy link
Member

@benaadams benaadams commented Jan 16, 2020 •
edited
Loading

Take advantage of the newly-exposed dotnet/runtime#706.

Currently does an unnecessary EC capture; then on callback an unnecessary restore which is then thrown away on the queue to threadpool

image

Requested by @davidfowl in dotnet/runtime#937
@ghost ghost added the area-servers label Jan 16, 2020
@benaadams
Copy link
Member Author

Is aspnet using a way old version of the runtime? Like, so last year?
@Tratcher
Copy link
Member

Is aspnet using a way old version of the runtime? Like, so last year?

Yup. We're almost able to take an update.
@analogrelay analogrelay added this to the 5.0.0-preview1 milestone Jan 21, 2020
@analogrelay
Copy link
Contributor

Take advantage of the newly-exposed #706.

Is this the correct issue link? It doesn't seem related to me... Did you mean dotnet/runtime#706 ?
@benaadams
Copy link
Member Author

Did you mean dotnet/runtime#706 ?

Yes; updated. The change was introduced so this change could be made in aspnet dotnet/runtime#937
@benaadams
Copy link
Member Author

Rebased
@benaadams
Copy link
Member Author

Looks like the runtime is 5.0.🚀

😄
@halter73 halter73 merged commit 76b0dff into dotnet:master Jan 28, 2020
@halter73
Copy link
Member

Thanks!
@benaadams benaadams deleted the saea branch January 28, 2020 20:39
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

5 participants

@benaadams @Tratcher @analogrelay @halter73 @amcasey