Skip to content

Conversation

@tomjebo
Copy link
Collaborator

@tomjebo tomjebo commented Mar 21, 2025

…types for v4 per #1769

@tomjebo
Copy link
Collaborator Author

tomjebo commented Mar 21, 2025

TODO:

  • remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs
@github-actions
Copy link

Test Results

    55 files   -   4      55 suites   - 4   52m 0s ⏱️ -29s
 2 041 tests ±  0   2 038 ✅ ±  0   3 💤 ±0  0 ❌ ±0 
31 933 runs   - 234  31 897 ✅  - 234  36 💤 ±0  0 ❌ ±0 

Results for commit e0eb6a4. ± Comparison against base commit d596354.

Copy link
Collaborator

@mikeebowen mikeebowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a breaking change? Should we create a v4 branch and merge it into that?

@mikeebowen
Copy link
Collaborator

reminder: before merging this for v4.0 , remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs

We should make an issue for this and add it to the v4 milestone

@tomjebo
Copy link
Collaborator Author

tomjebo commented Mar 21, 2025

reminder: before merging this for v4.0 , remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs

We should make an issue for this and add it to the v4 milestone

after #1905 merges to main, I'll add the code to this PR to remove the obsolete attribute entries.
@mikeebowen I've changed this PR to draft and added a todo task to remove the attribute entries.

@tomjebo tomjebo marked this pull request as draft March 21, 2025 18:52
@tomjebo
Copy link
Collaborator Author

tomjebo commented Mar 21, 2025

reminder: before merging this for v4.0 , remove the _attributeData entries from C:\source\repos\Open-XML-SDK\gen\DocumentFormat.OpenXml.Generator.Models\Generators\Elements\DataModelWriterExtensions.cs

We should make an issue for this and add it to the v4 milestone

I labeled it with v4.0 milestone initially. The original issue #1769 I closed. I don't think we need a new issue.

@tomjebo
Copy link
Collaborator Author

tomjebo commented Mar 21, 2025

Isn't this a breaking change? Should we create a v4 branch and merge it into that?

I can also do this if we decide that's the way to go. But it will have to wait until the PR is no longer draft.

@tomjebo tomjebo requested a review from mikeebowen March 21, 2025 18:58
@tomjebo tomjebo changed the base branch from main to release/v4.0.0 March 21, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants