Fix async GlobalSetup/Cleanup with InProcessEmit toolchain #2109
+180 −27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
timcassell force-pushed the async-globalsetup-inprocessemit branch from a18e5c4 to d7ceb27 Compare timcassell force-pushed the async-globalsetup-inprocessemit branch from d7ceb27 to 79ffa8d Compare timcassell force-pushed the async-globalsetup-inprocessemit branch 4 times, most recently from c4a07b0 to ac7210d Compare timcassell force-pushed the async-globalsetup-inprocessemit branch 2 times, most recently from 4618084 to 35948a1 Compare timcassell force-pushed the async-globalsetup-inprocessemit branch from 35948a1 to a0ebccf Compare 
timcassell force-pushed the async-globalsetup-inprocessemit branch from a0ebccf to a84da10 Compare timcassell force-pushed the async-globalsetup-inprocessemit branch from a84da10 to f27e83b Compare timcassell force-pushed the async-globalsetup-inprocessemit branch from f27e83b to 95c5485 Compare 
timcassell force-pushed the async-globalsetup-inprocessemit branch from 95c5485 to ea5639b Compare 
adamsitnik approved these changes Nov 26, 2024
There was a problem hiding this comment.
LGTM, thank you for providing the fix @timcassell and apologies for not noticing the PR (due to the fact that I work on the .NET Team I get few dozens of GH notifications a day).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #1738 and fixes #2236.