Skip to content

Fix Python 3.14 test failures #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Python 3.14 test failures #137

wants to merge 2 commits into from

Conversation

gotmax23
Copy link

See the individual commit messages for more information about each change. This PR was created during the process of bootstrapping Python 3.14 for Fedora Linux.
@gotmax23
tests: fix pathlib.PurePosixPath repr on py3.14
4cf05de 
``` fish for i in python3.{9,10,11,12,13,14} echo -n "$i " $i -c 'import pathlib; print(repr(pathlib.PurePosixPath))' end ``` ``` python3.9 <class 'pathlib.PurePosixPath'> python3.10 <class 'pathlib.PurePosixPath'> python3.11 <class 'pathlib.PurePosixPath'> python3.12 <class 'pathlib.PurePosixPath'> python3.13 <class 'pathlib._local.PurePosixPath'> python3.14 <class 'pathlib.PurePosixPath'> ```
@gotmax23
words: fix alphabet_sort exception handling for py3.14
9fa73b3 
As of python/cpython#121395, the format of the list.index exception has changed and parsing it like this no longer works. Relying on implementation details like this is always risky, so this solution should be more future-proof.
@auto-assign auto-assign bot requested a review from domdfcoding August 26, 2025 22:10
@MeggyCal
Copy link

MeggyCal commented Sep 15, 2025 •
edited
Loading

Hi, your patch didn't fix my Python 3.14 build, it was also necessary to add one more fix:

Index: domdf_python_tools-3.10.0/tests/test_paths.py =================================================================== --- domdf_python_tools-3.10.0.orig/tests/test_paths.py +++ domdf_python_tools-3.10.0/tests/test_paths.py @@ -925,7 +925,7 @@ else: @pytest.mark.parametrize("path", _from_uri_paths) -@pytest.mark.parametrize("left_type", [pathlib.PurePath, pathlib.Path, PathPlus]) +@pytest.mark.parametrize("left_type", [pathlib.Path, PathPlus]) def test_pathplus_from_uri(path: str, left_type: Type): assert PathPlus.from_uri(left_type(path).as_uri()).as_posix() == path

This is not a review, I am just working on Python 3.14 integration in openSUSE and discovered this issue as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@gotmax23 @MeggyCal @domdfcoding