Skip to content

Respect precision when casting to datetime #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2025
Merged

Respect precision when casting to datetime #3278

merged 4 commits into from
Oct 22, 2025

Conversation

@angelamayxie
Copy link
Contributor

@angelamayxie angelamayxie commented Oct 22, 2025 •
edited
Loading

Also explicitly cast datetime to max precision during comparisons

  • fixes broken ld tests (dolthub/ld#21555)
@angelamayxie angelamayxie marked this pull request as ready for review October 22, 2025 20:58
@angelamayxie angelamayxie requested a review from jycor October 22, 2025 20:59
jycor
jycor approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@angelamayxie angelamayxie merged commit 70b084e into main Oct 22, 2025
8 checks passed
@angelamayxie angelamayxie deleted the angela/datetime branch October 22, 2025 21:23
@BrewTestBot BrewTestBot mentioned this pull request Oct 23, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@angelamayxie @jycor