Add support for multi-line field options #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wouterj force-pushed the field-options-multiline branch from 05f7960 to 2f0e6d4 Compare 
| Out of curiosity, why do you want to implement this? I suppose you want to improve Symfony's or Doctrine's docs, maybe a specific page? |
greg0ire reviewed Sep 20, 2022
Oh, good question! 🤦 I'm planning to add alt texts to all figures in the Symfony docs (ref symfony/symfony-docs#16895 ). As these can be quite long, I want to use line breaks to conform to our soft 72 character limit in the Symfony docs. |
wouterj force-pushed the field-options-multiline branch 2 times, most recently from d211107 to b909c1f Compare | Thanks for the review! I've refactored the changes a bit, to use a VO instead of the array structures. I also added the test cases you suggested. |
wouterj force-pushed the field-options-multiline branch from b909c1f to a8207ba Compare greg0ire reviewed Sep 20, 2022
wouterj force-pushed the field-options-multiline branch from a8207ba to 7b4237c Compare 
wouterj force-pushed the field-options-multiline branch from 7b4237c to 9a83515 Compare greg0ire approved these changes Sep 20, 2022
| Thanks @wouterj ! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refs https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#field-lists