Skip to content

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Feb 5, 2018

Forbids useless things like:

/** Created by PhpStorm. */
/**  * Constructor.  */
/**  * Foo getter.  */

Fixable, but with one issue: slevomat/coding-standard#260

@Majkl578 Majkl578 added this to the 3.0.0 milestone Feb 5, 2018
@Majkl578 Majkl578 force-pushed the sniff/ForbiddenComments branch from b1b7d3f to b33c0a5 Compare February 5, 2018 22:51
@Majkl578
Copy link
Contributor Author

Majkl578 commented Feb 5, 2018

@kukulich Passed with 4.4, thanks!

@Majkl578 Majkl578 removed the WIP label Feb 5, 2018
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I could come up with examples where the expressions would be too loose, but it's not worth it. Let's try them and adjust if they cause trouble. I assume we don't have enough useful comments to trigger these anyways.

@Ocramius Ocramius self-assigned this Feb 6, 2018
@Ocramius Ocramius closed this in bfd472f Feb 6, 2018
@Ocramius
Copy link
Member

Ocramius commented Feb 6, 2018

Manually merged in bfd472f - thanks @Majkl578!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants