[WIP] Disallow complex conditional expressions

[carusogabriel]

Related to doctrine/dbal#2980 (comment)

[alcaeus]

@Majkl578 you added this to the 3.0 milestone - is there a sniff we can use or is it just considered a guideline?

[kukulich]

I can prepare the sniff. However there are already some new useful sniffs so I do a release of Slevomat CS so everyone can test them and report bugs.

It's also possible to merge some PR here and test them in dev-master together.

[Ocramius]

Deferred for now

[kukulich]

Can someone please make a better explanation what this sniff should do?

Examples would be perfect :)

[carusogabriel]

Maybe doctrine/dbal#2980 (comment) and #18 (comment) is something to start but is basically split long conditions (maybe a Sniffers configurable with how many checks are inside it?)

[lcobucci]

@carusogabriel @kukulich it might be quite tricky to implement the automatic fix fo this though...

[Ocramius]

I'm removing the 4.0.0 milestone here.

I don't think this is worth adding an auto-fixer, btw.

[carusogabriel]

Should we give up on this one?

[deeky666]

The question is what does "long" mean here. Does it mean to disallow boolean operators like && and ||?

[greg0ire]

IMO long means longer than 120 chars. I don't understand what's the proposed replacement, a code sample would help, because the related issues shows something quite simple, that doesn't seem applicable to if statements containing big blocks of code.

[Ocramius]

IMO long means longer than 120 chars

long as in NPath complexity > 8 or such.

if ($foo === 1 && $bar === 2 && $baz === 3 && $tar === 4) { // too long - 16 paths

if ($foo === 1 && $bar === 2 && $baz === 3) { // acceptable - 8 paths

[greg0ire]

long as in NPath complexity > 8 or such.

A better wording might be "complex" instead of "long" then :P

[Ocramius]

@greg0ire adapted title 👍